First time here? Check out the FAQ!
THIS IS A TEST INSTANCE. Feel free to ask and answer questions, but take care to avoid triggering too many notifications.
0

dissector packet-nvme-tcp not showing up

Downloaded latest binary (3.0.7) and git tree for wireshark. I see that the dissector for packet-nvme-tcp is being compiled by default. But in the binary, in the dissector list shown via Analyze->Enabled Protocols, that dissector is not showing up. Where could I look to determine why this is the case, either in the build or hidden in the binary?

MWWUNDER's avatar
1
MWWUNDER
asked 2019-12-12 01:16:22 +0000
edit flag offensive 0 remove flag close merge delete

Comments

add a comment see more comments

1 Answer

0

packet-nvme-tcp is not part of the 3.0.7 release. You can verify this by looking for the packet-nvme-tcp.c dissector in the various releases; you won't find it in master-3.0, but you will find it in master-3.2 or in master.

So, if you want to use that dissector, you will either need to download the 3.2.0rc2 release from the Wireshark download page, or one of the recent automated builds from the automated builds location.

If a suitable installer isn't available for your platform, then you may have to download the source code and build Wireshark yourself. Refer to the Wireshark Developer's Guide for help on building Wireshark for your platform.

cmaynard's avatar
11.1k
cmaynard
answered 2019-12-12 02:44:54 +0000
edit flag offensive 0 remove flag delete link

Comments

Downloaded latest binary (3.0.7) and git tree for wireshark. I see that the dissector for packet-nvme-tcp is being compiled by default.

Note that the git tree for the master branch has packet-nvme-tcp.c, but the git tree for the master-3.0 branch does not; if you get a git tree, it doesn't necessarily reflect what the release whose binary you installed has.

Guy Harris's avatar Guy Harris (2019-12-12 05:40:30 +0000) edit

Thanks all for fast response! I was thrown off when I checked out a branch from master at tag v3.0.7 and cmake included packet-nvme-tcp.c in the build process. So it was not clear where in the various control files it was not adding that dissector .o into the final binary. Where is that decision controlled? I will look for one of the more recent builds as suggested. Cheers.

MWWUNDER's avatar MWWUNDER (2019-12-12 16:17:57 +0000) edit

You can refer to the Release Policy for full clarification, but I'll just quote one relevant statement here:

This Maintenance release has to adhere to the same policy of consistent release contents, so does not contain new or changed features, but only repairs of detected flaws.

cmaynard's avatar cmaynard (2019-12-12 17:03:04 +0000) edit

I was thrown off when I checked out a branch from master at tag v3.0.7 and cmake included packet-nvme-tcp.c in the build process.

What command did you use to do that? I did a "git clone" of Wireshark, followed by `"git checkout tags/v3.0.7", and there's no trace of any reference to packet-nvme-tcp.c in the tree. ("git checkout tags/v3.0.7 -b master-3.0" produced the same result.)

Guy Harris's avatar Guy Harris (2019-12-12 19:49:56 +0000) edit

My bad, my history shows I did the git checkout -b <new_branch_name> but failed to indicate the <start_point> tag correctly. Have downloaded and verified v3.2.0rc2 does indeed provide that dissector as mentioned. Thanks for everyone's help.

MWWUNDER's avatar MWWUNDER (2019-12-12 21:27:08 +0000) edit
add a comment see more comments

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account. This space is reserved only for answers. If you would like to engage in a discussion, please instead post a comment under the question or an answer that you would like to discuss.

Add Answer