Revision history [back]

Revision 2

updated 2020-01-10 12:03:50 +0000

it's ok to sizeof(nspr_hd_v20_t) or it should be sizeof(nspr_pktracefull_v20_t) ?

the commit is : https://code.wireshark.org/review/gitweb?p=wireshark.git

case NSPR_RELTIME_V20:
                 {
+                    if (!nstrace_ensure_buflen(nstrace, nstrace_buf_offset, sizeof(nspr_hd_v20_t), err, err_info))
+                        return FALSE;
                     nspr_pktracefull_v20_t *fp20 = (nspr_pktracefull_v20_t *) &nstrace_buf[nstrace_buf_offset];
                     if (nspr_getv20recordsize((nspr_hd_v20_t *)fp20) == 0) {
                         *err = WTAP_ERR_BAD_FILE;

the type of varible which will be used next is "nspr_pktracefull_v20_t", so i think sizeof(nspr_pktracefull_v20_t) is better

Revision 1

eaglegai

asked 2020-01-10 12:01:49 +0000

it's ok to sizeof(nspr_hd_v20_t) or it should be sizeof(nspr_pktracefull_v20_t) ?

the commit is : ~~https://code.wireshark.org/review/gitweb?p=wireshark.git~~

https://code.wireshark.org/review/gitweb?p=wireshark.git
case NSPR_RELTIME_V20:
                 {
+                    if (!nstrace_ensure_buflen(nstrace, nstrace_buf_offset, sizeof(nspr_hd_v20_t), err, err_info))
+                        return FALSE;
                     nspr_pktracefull_v20_t *fp20 = (nspr_pktracefull_v20_t *) &nstrace_buf[nstrace_buf_offset];
                     if (nspr_getv20recordsize((nspr_hd_v20_t *)fp20) == 0) {
                         *err = WTAP_ERR_BAD_FILE;

WTAP_ERR_BAD_FILE;

the type of varible which will be used next is "nspr_pktracefull_v20_t", so i think sizeof(nspr_pktracefull_v20_t) is better