Hi, I am new to wireshark development. I am trying to upstream my dissector but the gitlab CI is failing. this is the link to the CI -> https://gitlab.com/riyadixitagra/wire...
If I look at the most recent pipeline for your pull request - which, rather than pipelines on your own repository, are what matter for upstreaming - the commit check job failed with
Checking: /builds/riyadixitagra/wireshark-pldm
License 'UNKNOWN' for 'epan/dissectors/packet-pldm-base.c' is not allowed.
License 'UNKNOWN' for 'epan/dissectors/packet-pldm-base.h' is not allowed.
License 'UNKNOWN' for 'epan/dissectors/packet-pldm.c' is not allowed.
FAILED
This is because you must, at minimum, have a comment header that specifies a license for the code. It should probably also include a copyright notice to go along with the license, plus some other information, e.g.:
/* {file name}
* {Short summary of what's in the file}
*
* Wireshark - Network traffic analyzer
* By Gerald Combs <[email protected]>
* Copyright 1998 Gerald Combs
*
* {additional information if you want}
*
* SPDX-License-Identifier: GPL-2.0-or-later
*/
Try adding that to your source files (all three of them) in your personal GitHub repository; that should trigger a new build of the pull request.
(And ask further questions on your pull request, rather than here, so that the issues can be directly tracked on the pull request.)
(Not that 1998 is a requirement; see, for example, epan/epan.h, epan/epan_dissect.h, and epan/epan.c.)
Thanks. i will try this.
Comments
You're following the steps in 3.10.1. Creating Merge Requests and SubmittingPatches?
yes, I am.